fix: detect Python methods as properties correctly #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
changed the title
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-forest-0a29f6210-1111.centralus.azurestaticapps.net |
dgozman
reviewed
Jul 31, 2023
src/format_python.js
Outdated
| return { key: 'd', title: 'Deprecated' }; | ||
| if (member.kind === 'event') | ||
| return { key: 'c', title: 'Events' }; | ||
| if (member.kind === 'property' || (member.kind === 'method' && !member.async && member.argsArray.length === 0)) |
There was a problem hiding this comment.
I'd instead introduce renderSyncNoArgsMethodAsProperty(): boolean method and put this logic into generator.js.
mxschmitt
force-pushed
the
fix-python-sorting
branch
from
75a7bd0
to
83a7ee3
Compare
dgozman
approved these changes
Jul 31, 2023
| * srcDir: string, | ||
| * outDir: string, | ||
| * formatter: GeneratorFormatter, | ||
| * renderSyncNoArgsMethodAsProperty?: boolean, |
There was a problem hiding this comment.
nit: I think this is more of a GeneratorFormatter property rather than generator's parameter, but this way also works.
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-forest-0a29f6210-1111.centralus.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-forest-0a29f6210-1111.centralus.azurestaticapps.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/playwright-python#2025